feat: add support for .NET SDK V4 #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96malhar
approved these changes
Oct 16, 2024
normj
requested changes
Oct 16, 2024
There was a problem hiding this comment.
I think the GetParametersByPathAsync method in SystemsManagerProcessor needs a null check for the response.Parameters property.
Also I think the code is okay but for defensive code purposes in the GetDataAsync method of AppConfigProcessor maybe add ?? new Dictionary<string, string> from the return of the private methods it calls.
Fixed |
normj
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
DOTNET-7753
Description of changes: